Bring back the button mapping of the OFW in iPod Video

[INGRAMLI]

So i am finally compiled the source code....the next question is, how is build a patch from scratch? in the wiki it seems only mentioned how to add existing patches, but not making new ones

[Febs]

http://www.rockbox.org/twiki/bin/view/Main/WorkingWithPatches#Creating_A_Patch

[AlexP]

In your case you don't really want to create a patch, as a patch is a file that shows what source code has been changed so you can distribute it to other people.  Just edit the code that you want to change directly, and then compile.

[cool_walking_]

Please document problems you have solved yourself so that future forum readers can benefit.  How did you fix the "Cygwin closing itself" issue?

[INGRAMLI]

In your case you don't really want to create a patch, as a patch is a file that shows what source code has been changed so you can distribute it to other people.  Just edit the code that you want to change directly, and then compile.

I tried to understand what is being said in the keymap-ipod.c, but i cant find those code/definitions ...for instance, what is  meant by "BUTTON_REL"? and what is "static const struct button_mapping button_context_keyboard"?The whole file seems to be a whole brunch of codes rather than a ini file that could be understood in the Windows

edit: cool_walking_, the problem is related to the compatibility with Windows XP Pro in Japanese, when i switched back to English OS, the problem is solved. I guess Cygwin is not being written/tested to run in OS in language other than Eng.

[AlexP]

I tried to understand what is being said in the keymap-ipod.c, but i cant find those code/definitions ...for instance, what is  meant by "BUTTON_REL"? and what is "static const struct button_mapping button_context_keyboard"?The whole file seems to be a whole brunch of codes rather than a ini file that could be understood in the Windows

Why is Windows relevant at all?  You are looking in a Rockbox source file.  Try looking at the example keymap in that folder, it explains what some of it does.

[INGRAMLI]

I tried to understand what is being said in the keymap-ipod.c, but i cant find those code/definitions ...for instance, what is  meant by "BUTTON_REL"? and what is "static const struct button_mapping button_context_keyboard"?The whole file seems to be a whole brunch of codes rather than a ini file that could be understood in the Windows

Why is Windows relevant at all?  You are looking in a Rockbox source file.  Try looking at the example keymap in that folder, it explains what some of it does.

example keymap in which folder?i cant really see it, and the name of this file is?

[saratoga]

I tried to understand what is being said in the keymap-ipod.c, but i cant find those code/definitions ...for instance, what is  meant by "BUTTON_REL"? and what is "static const struct button_mapping button_context_keyboard"?The whole file seems to be a whole brunch of codes rather than a ini file that could be understood in the Windows

Why is Windows relevant at all?  You are looking in a Rockbox source file.  Try looking at the example keymap in that folder, it explains what some of it does.

example keymap in which folder?i cant really see it, and the name of this file is?

"keymap-newtarget.c"

(took me 10 seconds to spot looking at the folder you described.  Next time check before asking)

[INGRAMLI]

I tried to understand what is being said in the keymap-ipod.c, but i cant find those code/definitions ...for instance, what is  meant by "BUTTON_REL"? and what is "static const struct button_mapping button_context_keyboard"?The whole file seems to be a whole brunch of codes rather than a ini file that could be understood in the Windows

Why is Windows relevant at all?  You are looking in a Rockbox source file.  Try looking at the example keymap in that folder, it explains what some of it does.

example keymap in which folder?i cant really see it, and the name of this file is?

"keymap-newtarget.c"

(took me 10 seconds to spot looking at the folder you described.  Next time check before asking)

i can find this document, but it does not give explanation on the code that i asked above in plain language, for instance,

#include "config.h"
#include "action.h"
#include "button.h"

".........In ../action.h there is an enum with all the used ACTION_ codes......"
what is "enum"? and like this one,

"static const struct button_mapping button_context_standard"
i have totally no idea what does it mean, please, i want some explanations that can be read by non-programmers 

[GodEater]

There are no explanations that can be read by non-programmers, since what you're doing by editting that file is called "programming", which makes you a programmer.

What I understand from your posts is that you have no experience of C - and therefore need to go and read up on it. The Rockbox forums are not the place to teach you the basics of C programming. We can help with Rockbox specific stuff - but the questions you're asking are extremely basic - not specific to Rockbox yet.

[INGRAMLI]

There are no explanations that can be read by non-programmers, since what you're doing by editting that file is called "programming", which makes you a programmer.

What I understand from your posts is that you have no experience of C - and therefore need to go and read up on it. The Rockbox forums are not the place to teach you the basics of C programming. We can help with Rockbox specific stuff - but the questions you're asking are extremely basic - not specific to Rockbox yet.

I understand that i do not have the basic knowledge to do programming, but i am only one step away from my target. Can u do me a favor by telling me which code is the one that takes the screen back to the folder where the song is previous chosen from the WPS(what i mean is, when the select button is chosen, the screen back to that song folder, and that is the one that i want to change in the keymap-ipod.c

[bluebrother]

I understand that i do not have the basic knowledge to do programming, but i am only one step away from my target.

What makes you so sure about this claim?

[INGRAMLI]

I understand that i do not have the basic knowledge to do programming, but i am only one step away from my target.

What makes you so sure about this claim?

because i managed to go one level up in the folder using button_menu instead of the default button_left (except in WPS), therefore i guess all i need is the code that have effect in the WPS which has button_select as default.

edit: finally i put an end to the quest.........here's what i have changed:

static const struct button_mapping button_context_standard[]  =
{ ACTION_STD_CANCEL,        BUTTON_MENU,                        BUTTON_NONE }



static const struct button_mapping button_context_wps[]  =
{ ACTION_WPS_BROWSE,    BUTTON_MENU|BUTTON_REL,             BUTTON_MENU },
    { ACTION_WPS_CONTEXT,   BUTTON_SELECT|BUTTON_REPEAT,        BUTTON_SELECT },
    { ACTION_WPS_MENU,          BUTTON_SELECT|BUTTON_REL,         BUTTON_SELECT },
    { ACTION_WPS_QUICKSCREEN,   BUTTON_MENU|BUTTON_REPEAT,      BUTTON_MENU },

the process is similar to reverse engineering, since i got virtually no knowledge related to C programming nor rockbox though...